DO NOT MERGE first cut at centralising hardware definitions.#170
Open
penfold42 wants to merge 1 commit intodawsonjon:masterfrom
Open
DO NOT MERGE first cut at centralising hardware definitions.#170penfold42 wants to merge 1 commit intodawsonjon:masterfrom
penfold42 wants to merge 1 commit intodawsonjon:masterfrom
Conversation
Owner
|
There is something quite similar under the TFT branch, might be worth a quick look. |
Contributor
Author
:) rather! Is tft where you're currently working ? |
Owner
|
Yes, I've done a bit more development work in the TFT branch, it's not
quite ready for another release yet though. I think we could take this PR
as it is when you are ready to go, it should be very easy for me to merge
it back into the TFT branch as I go. It was more for information than
anything.
…On Fri, 28 Mar 2025, 12:27 penfold42, ***@***.***> wrote:
There is something quite similar under the TFT branch, might be worth a
quick look.
:) rather!
Is tft where you're currently working ?
Theres a few missed - do you want a PR for them? Or I can just paste the
few in here if thats easier...
—
Reply to this email directly, view it on GitHub
<#170 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFPFX5WHPKZEEWORURM7CT2WU5XDAVCNFSM6AAAAABZ62TEF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONRRGIZDSMRTHA>
.
You are receiving this because you commented.Message ID:
***@***.***>
[image: penfold42]*penfold42* left a comment (dawsonjon/PicoRX#170)
<#170 (comment)>
There is something quite similar under the TFT branch, might be worth a
quick look.
:) rather!
Is tft where you're currently working ?
Theres a few missed - do you want a PR for them? Or I can just paste the
few in here if thats easier...
—
Reply to this email directly, view it on GitHub
<#170 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFPFX5WHPKZEEWORURM7CT2WU5XDAVCNFSM6AAAAABZ62TEF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONRRGIZDSMRTHA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had some time today so went through looking for all the hard coded pin definitions I could find.
The pio and adc channel stuff is still to be done...
untested, but does build
Should be a good start for #169