fix(release): Tighten version constant regex#463
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR tightens the VersionRbFile parsing/updating regex so the release tooling targets the intended VERSION constant even when other constants like SPEC_VERSION are present in the file.
Changes:
- Tighten regexes used by
VersionRbFile#update_versionand.current_version_from_contentto avoid matchingSPEC_VERSION. - Add new fixture version files containing both
SPEC_VERSIONandVERSION. - Add a regression test ensuring
VERSIONis read/updated correctly whenSPEC_VERSIONis present.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| toys-release/toys/.lib/toys/release/version_rb_file.rb | Updates regexes used to find and replace the version constant. |
| toys-release/toys/.test/test_version_rb_file.rb | Adds coverage for files that define both SPEC_VERSION and VERSION. |
| toys-release/toys/.test/.data/version5.rb | New expected fixture content after updating VERSION in presence of SPEC_VERSION. |
| toys-release/toys/.test/.data/version6.rb | New input fixture containing both SPEC_VERSION and VERSION. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dazuma
force-pushed
the
pr/version-constant
branch
from
640e15e to
7f9b4b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.