Skip to content

multi(release): Several small updates to toys-release#469

Merged
dazuma merged 1 commit intomainfrom
pr/release-updates
Mar 20, 2026
Merged

multi(release): Several small updates to toys-release#469
dazuma merged 1 commit intomainfrom
pr/release-updates

Conversation

@dazuma
Copy link
Owner

@dazuma dazuma commented Mar 20, 2026

fix(release): gen-gh-pages and gen-workflows no longer ask for confirmation if a file to generate is unchanged
fix(release): Release versions can now omit version fields beyond major, e.g. version "1" is now legal

@dazuma dazuma requested a review from Copilot March 20, 2026 01:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the toys-release generators to avoid prompting when generated output is unchanged, and relaxes version parsing/updating so major-only versions (e.g. "1") are considered valid.

Changes:

  • Skip overwrite/create confirmations when the destination file already exists and has identical content to the generated output.
  • Replace existing destinations (including non-regular files) after confirmation by removing the existing entry before writing.
  • Update VersionRbFile’s version-matching regex to allow versions with only a major segment.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File Description
toys-release/toys/gen-workflows.rb Adds content-based “unchanged” detection and removes/recreates destinations on overwrite.
toys-release/toys/gen-gh-pages.rb Inlines destination checks into generate_file, adds “unchanged” short-circuit, and removes existing entries before writing.
toys-release/toys/.lib/toys/release/version_rb_file.rb Broadens VERSION regex to allow major-only versions when reading/updating.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dazuma dazuma force-pushed the pr/release-updates branch 2 times, most recently from 3083fb8 to 3943016 Compare March 20, 2026 01:33
fix(release): gen-gh-pages and gen-workflows no longer ask for confirmation if a file to generate is unchanged
fix(release): Release versions can now omit version fields beyond major, e.g. version "1" is now legal
@dazuma dazuma force-pushed the pr/release-updates branch from 3943016 to 30719f2 Compare March 20, 2026 01:50
@dazuma dazuma merged commit 3c59ae5 into main Mar 20, 2026
15 checks passed
@dazuma dazuma deleted the pr/release-updates branch March 20, 2026 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants