fix(pa11y-ci): added chrome launch path and necessary ignores #1043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
🔭🐙🐈 Test this branch here: https://db-ui.github.io/core/review/fix-pa11y-ci |
mfranzke
changed the title
mfranzke
requested review from
annsch,
bruno-sch,
dkolba and
nmerget
as code owners
mfranzke
added a commit
that referenced
this pull request
Jan 23, 2025
* fix(pa11y-ci): added chrome launch path https://www.npmjs.com/pa11y-ci#pa11y-ci-3-and-ubuntu * refactor: another try * refactor: added wcag false/positive ignore * refactor: wrong place * refactor: another try * refactor: another try
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to https://www.npmjs.com/pa11y-ci#pa11y-ci-3-and-ubuntu, this would have had been necessary after using
pa11y ciwith ubuntu versions higher than 20.04And we need to ignore false positives on color contrast checks.