Skip to content

fix: sticky table header depending on a sticky page header #1053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 27, 2025
Merged

fix: sticky table header depending on a sticky page header #1053

merged 2 commits into from
Jan 27, 2025

Conversation

@mfranzke
Copy link
Member

@mfranzke mfranzke commented Jan 3, 2025

Resolves #1052

@mfranzke mfranzke added bug Something isn't working community feedback labels Jan 3, 2025
@mfranzke mfranzke self-assigned this Jan 3, 2025
@mfranzke mfranzke linked an issue Jan 3, 2025 that may be closed by this pull request
Incompatibility between tables with sticky table header and page header #1052
Closed
@mfranzke mfranzke removed their assignment Jan 3, 2025
@mfranzke mfranzke changed the title feat: accomplish sticky header table cells depending on a sticky header fix: sticky header table cells depending on a sticky header Jan 3, 2025
@mfranzke mfranzke changed the title fix: sticky header table cells depending on a sticky header fix: sticky table header cells depending on a sticky header Jan 3, 2025
@mfranzke mfranzke changed the title fix: sticky table header cells depending on a sticky header fix: sticky table header depending on a sticky header Jan 3, 2025
@mfranzke mfranzke changed the title fix: sticky table header depending on a sticky header fix: sticky table header depending on a sticky page header Jan 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

🔭🐙🐈 Test this branch here: https://db-ui.github.io/core/review/1052-incompatibility-between-tables-with-sticky-table-header-and-page-header

@mfranzke mfranzke enabled auto-merge (squash) January 3, 2025 15:35
@github-actions github-actions bot added documentation Improvements or additions to documentation patterns labels Jan 3, 2025
@mfranzke mfranzke merged commit 9ec8055 into main Jan 27, 2025
12 checks passed
@mfranzke mfranzke deleted the 1052-incompatibility-between-tables-with-sticky-table-header-and-page-header branch January 27, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nmerget nmerget nmerget approved these changes

@dkolba dkolba Awaiting requested review from dkolba dkolba is a code owner

@annsch annsch Awaiting requested review from annsch annsch is a code owner

@bruno-sch bruno-sch Awaiting requested review from bruno-sch bruno-sch is a code owner

Assignees

No one assigned

Labels

bug Something isn't working community feedback documentation Improvements or additions to documentation patterns

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incompatibility between tables with sticky table header and page header

3 participants

@mfranzke @nmerget