Skip to content

refactor: guidelines 3.0 checkbox style #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 44 commits into from
Closed

refactor: guidelines 3.0 checkbox style #108

wants to merge 44 commits into from

Conversation

@mfranzke
Copy link
Member

@mfranzke mfranzke commented Oct 21, 2022 •
edited
Loading

Resolves #19

Backlog

  • Add tonality

QA feedback

  • dynamic border-width with formula n/16+0,5
  • correct margins in between label and checkbox using the variables
  • adapt new color placeholders
  • disabled state by background-color at an alpha of 0.25, but text and border by an opacity of 0.5

Additionally

  • docs/migrationGuide.adoc
  • Test-URLs: .pa11yci and tests/backstop.json

@mfranzke mfranzke added this to the Guidelines 3.0 milestone Oct 21, 2022
@mfranzke mfranzke self-assigned this Oct 21, 2022
@mfranzke mfranzke changed the base branch from main to dbux-3 October 21, 2022 07:24
@mfranzke mfranzke marked this pull request as draft October 21, 2022 07:24
@mfranzke mfranzke changed the title refactor: guidelines 3 checkbox style refactor: guidelines 3.0 checkbox style Oct 30, 2022
mfranzke and others added 14 commits November 4, 2022 06:43
@mfranzke
Merge branch 'dbux-3' into refactor-guidelines-3-checkbox-style
091c4b4
@mfranzke
Merge branch 'dbux-3' into refactor-guidelines-3-checkbox-style
4ba05fa
@mfranzke
refactor: simplified sizing by using aspect-ratio
1e8013d
@mfranzke
chore: added a comment
5801e95
@mfranzke
refactor: rework on the sizes available
c11970f
@mfranzke
Merge branch 'dbux-3' into refactor-guidelines-3-checkbox-style
fa6d3e5
@mfranzke
refactor: removed the obsolete large checkbox size
52c9942
@mfranzke
refactor: checkbox styling
744a2ec
@mfranzke
fix: checkbox spacings
8f794bb
@mfranzke
Merge branch 'dbux-3' into refactor-guidelines-3-checkbox-style
324ce29
@mfranzke
refactor: we even need to differentiate the font-size on sized icons …
de3d256 
…at some points
@mfranzke
Merge branch 'dbux-3' into refactor-guidelines-3-checkbox-style
3580918
@mfranzke
Merge branch 'dbux-3' into refactor-guidelines-3-checkbox-style
d071aa0
@mfranzke
Merge branch 'dbux-3' into refactor-guidelines-3-checkbox-style
6235216
mfranzke and others added 16 commits December 16, 2022 09:30
@mfranzke
test: fix html validate feedback
c0cc9b8
@mfranzke
chore: stylelint order feedback
9f20547
@mfranzke
refactor: needed to update DB UI Base with an enhanced mixin
9c0c6da
@mfranzke
Merge branch 'dbux-3' into refactor-guidelines-3-checkbox-style
2ea861d
@mfranzke
Merge branch 'dbux-3' into refactor-guidelines-3-checkbox-style
4cdee18
@mfranzke
refactor: aligned tonality display
c9d322c
@mfranzke
refactor: tonality display
32dcf4d
@mfranzke
Merge branch 'main' into refactor-guidelines-3-checkbox-style
91727a9
@mfranzke
chore: regenerated lock file
1b4c88a
@mfranzke
Merge branch 'dbux-3' into refactor-guidelines-3-checkbox-style
40fff63
@mfranzke
refactor: corrected the sizes
06d281e
@mfranzke
Merge branch 'dbux-3' into refactor-guidelines-3-checkbox-style
0625e96
@mfranzke
Merge branch 'dbux-3' into refactor-guidelines-3-checkbox-style
bb6347d
@mfranzke
Update checkbox.scss
51b655c
@mfranzke
docs: added entry to migrationguide
9a4f8e4
@mfranzke
refactor: added necessary references
dda5fb9
@mfranzke mfranzke marked this pull request as ready for review January 31, 2023 08:15
@mfranzke mfranzke marked this pull request as draft January 31, 2023 10:02
@mfranzke
Copy link
Member Author

mfranzke commented Apr 15, 2023

Closed in favour of https://github.com/db-ui/mono/issues/362

@mfranzke mfranzke closed this Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nmerget nmerget Awaiting requested review from nmerget nmerget is a code owner

@dkolba dkolba Awaiting requested review from dkolba dkolba is a code owner

@annsch annsch Awaiting requested review from annsch annsch is a code owner

Assignees

@mfranzke mfranzke

Labels

patterns

Projects

None yet

Milestone

Guidelines v3

Development

Successfully merging this pull request may close these issues.

Checkboxes (DB UX Design System v3)

2 participants

@mfranzke