fix: set border- and label-color for in/valid state of textarea, custom select and input #4258
+29
−27
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -153,6 +153,24 @@ $db-min-inline-size: var( | |||||||||||||||||||||
| } | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| @each $state, $variant in (valid: successful, invalid: critical) { | ||||||||||||||||||||||
| &[data-custom-validity="#{$state}"] > label, | ||||||||||||||||||||||
| &:has(> #{$selector}[data-custom-validity="#{$state}"]) > label { | ||||||||||||||||||||||
| color: var(--db-#{$variant}-on-bg-basic-emphasis-70-default); | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| @if ($selector == textarea) { | ||||||||||||||||||||||
| &:has(> #{$selector}[data-custom-validity="#{$state}"]) { | ||||||||||||||||||||||
| &::before, | ||||||||||||||||||||||
| &::after { | ||||||||||||||||||||||
| // necessary to force this override over the placeholder-content mixin's ::before rule | ||||||||||||||||||||||
| // to avoid the label to influence the border of the textarea | ||||||||||||||||||||||
| content: none !important; | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
|
|
@@ -369,6 +387,16 @@ $input-valid-types: | |||||||||||||||||||||
| #{colors.$db-adaptive-bg-basic-level-1-default} | ||||||||||||||||||||||
| ) !important; | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| &:is(textarea) { | ||||||||||||||||||||||
| @each $state, $variant in (valid: successful, invalid: critical) { | ||||||||||||||||||||||
| &[data-custom-validity="#{$state}"] { | ||||||||||||||||||||||
| border: var(--db-border-width-3xs) | ||||||||||||||||||||||
| solid | ||||||||||||||||||||||
| var(--db-#{$variant}-on-bg-basic-emphasis-70-default); | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
|
There was a problem hiding this comment.
Suggested change
We don't need this here replace https://github.com/db-ux-design-system/core-web/pull/4258/files#diff-fc8ed644a470e8653bcb58e284747ce63f7ab258a112d921ab5605159aa41a8cR204-R228 with: ` & { I don't know why there was a workaround for textarea but with this we set all adaptive colors like we should. |
||||||||||||||||||||||
| } | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| // label | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You cannot remove the content on
::beforeor::afterit is a workaround to ensure the floating label stays above the text. You see the problem, when you add a lot of text into the textarea.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the problem with long texts. We could handle it like that
This way, we would keep the workaround and ensure that the label does not influence the border of the textarea.