Skip to content

feat: added codespell #4619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 30 commits into
base: main
Choose a base branch
from
Draft

feat: added codespell #4619

wants to merge 30 commits into from

Conversation

mfranzke
Copy link
Collaborator

Proposed changes

Types of changes

  • Bugfix (non-breaking change that fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improvements to existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke self-assigned this Jul 24, 2025
@mfranzke mfranzke added the 🍄🆙improvement New feature or request label Jul 24, 2025
@mfranzke mfranzke moved this to 🏗 In development in UX Engineering Team Backlog Jul 24, 2025
@mfranzke mfranzke added 🧪test Improvements/bugs for testing-framework 🍒 cherryPick Code that we should adapt from one repository to another. labels Jul 24, 2025
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/feat-added-codespell

@github-actions github-actions bot added the 🚢📀cicd Changes inside .github folder label Jul 24, 2025
@mfranzke mfranzke moved this from 🏗 In development to 👀 In review in UX Engineering Team Backlog Jul 30, 2025
@mfranzke mfranzke removed their assignment Jul 30, 2025
@mfranzke mfranzke marked this pull request as ready for review July 30, 2025 06:13
@mfranzke mfranzke requested a review from nmerget as a code owner July 30, 2025 06:13
@mfranzke mfranzke enabled auto-merge (squash) July 30, 2025 06:13
@nmerget
Copy link
Collaborator

nmerget commented Jul 30, 2025

We should find a npm package which does the same to lint it like markdownlint etc.

If we just add it in the pipeline we wouldn't have any possibility to check issues locally

@mfranzke mfranzke moved this from 👀 In review to 🏗 In development in UX Engineering Team Backlog Jul 30, 2025
@mfranzke mfranzke marked this pull request as draft July 30, 2025 10:50
auto-merge was automatically disabled July 30, 2025 10:50

Pull request was converted to draft

@mfranzke
Copy link
Collaborator Author

We should find a npm package which does the same to lint it like markdownlint etc.

If we just add it in the pipeline we wouldn't have any possibility to check issues locally

I'm not totally sure about this – I did a quick research, but haven't found anything as a node module. I'll follow up on this, but maybe it's something that only the pipeline could tell us finally.

@mfranzke
Copy link
Collaborator Author

We should find a npm package which does the same to lint it like markdownlint etc.
If we just add it in the pipeline we wouldn't have any possibility to check issues locally

I'm not totally sure about this – I did a quick research, but haven't found anything as a node module. I'll follow up on this, but maybe it's something that only the pipeline could tell us finally.

"code-spell" instead of "codespell" does the trick …

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 cherryPick Code that we should adapt from one repository to another. 🚢📀cicd Changes inside .github folder 🍄🆙improvement New feature or request 🧪test Improvements/bugs for testing-framework
Projects
Status: 🏗 In development
Development

Successfully merging this pull request may close these issues.

2 participants