-
Notifications
You must be signed in to change notification settings - Fork 11
fix(docs): leftovers of attribute changes from last major release #4681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/fix-converted-leftovers |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes documentation leftovers from a previous major release by updating outdated attribute names in tooltip examples. The changes address inconsistencies where the old describedbyid
attribute was still being used instead of the standard aria-describedby
attribute.
- Updates tooltip documentation examples across React, Vue, and Angular frameworks
- Fixes test file to use correct attribute name
- Ensures consistency with accessibility standards by using proper ARIA attributes
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
File | Description |
---|---|
tooltip.spec.tsx | Updates test case to use aria-describedby instead of describedbyid |
Vue.md | Fixes Vue documentation example to use correct ARIA attribute |
React.md | Updates React documentation example with proper attribute name |
Angular.md | Corrects Angular documentation example to use standard ARIA attribute |
Proposed changes
Converted some leftovers of attribute changes from last major release 3.x out the changes by #4476, mainly for tooltip documentation.
partly resolves #4680 (the documentation part)
Types of changes
Further comments