Skip to content

refactor(input:read-only): aligned technical implementation to Figma specification #4688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 12, 2025
Merged

refactor(input:read-only): aligned technical implementation to Figma specification #4688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
929caae
refactor: remove values to display the placeholder directly
mfranzke Aug 6, 2025
3840cdc
auto update snapshots (#4689)
github-actions[bot] Aug 6, 2025
b8f40bb
refactor: changed the variable
mfranzke Aug 6, 2025
ac86667
refactor: css condition to scss condition
mfranzke Aug 6, 2025
8c0bc9d
Revert "refactor: css condition to scss condition"
mfranzke Aug 6, 2025
4eac6c8
Merge branch 'main' into 4334-read-only-feld-weicht-in-der-entwicklun…
mfranzke Aug 12, 2025
a903f9e
Merge branch 'main' into 4334-read-only-feld-weicht-in-der-entwicklun…
michaelmkraus Aug 12, 2025
5d5e2d1
Merge branch 'main' into 4334-read-only-feld-weicht-in-der-entwicklun…
michaelmkraus Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified ...hContrast/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions ...m-highContrast/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,10 @@
- status
- link "Readonly"
- text: Label
- textbox "Label": (Default) False
- textbox "Label"
- status
- text: Label
- textbox "Label": "True"
- textbox "Label"
- status
- link "Validation"
- text: Label
Expand Down
Binary file modified .../chromium/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions ...wcase/chromium/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,10 @@
- status
- link "Readonly"
- text: Label
- textbox "Label": (Default) False
- textbox "Label"
- status
- text: Label
- textbox "Label": "True"
- textbox "Label"
- status
- link "Validation"
- text: Label
Expand Down
Binary file modified ...e/firefox/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions ...owcase/firefox/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,10 @@
- status
- link "Readonly"
- text: Label
- textbox "Label": (Default) False
- textbox "Label"
- status
- text: Label
- textbox "Label": "True"
- textbox "Label"
- status
- link "Validation"
- text: Label
Expand Down
4 changes: 2 additions & 2 deletions .../mobile-chrome/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,10 @@
- status
- link "Readonly"
- text: Label
- textbox "Label": (Default) False
- textbox "Label"
- status
- text: Label
- textbox "Label": "True"
- textbox "Label"
- status
- link "Validation"
- text: Label
Expand Down
4 changes: 2 additions & 2 deletions .../mobile-safari/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,10 @@
- status
- link "Readonly"
- text: Label
- textbox "Label": (Default) False
- textbox "Label"
- status
- text: Label
- textbox "Label": "True"
- textbox "Label"
- status
- link "Validation"
- text: Label
Expand Down
4 changes: 2 additions & 2 deletions ...howcase/webkit/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,10 @@
- status
- link "Readonly"
- text: Label
- textbox "Label": (Default) False
- textbox "Label"
- status
- text: Label
- textbox "Label": "True"
- textbox "Label"
- status
- link "Validation"
- text: Label
Expand Down
Binary file modified ...ebkit/DBPopover-should-match-screenshot-1/DBPopover-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion packages/components/src/styles/internal/_form-components.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@ $input-valid-types:
&:is(input, textarea):not(:disabled):read-only {
background-color: var(
--db-textarea-read-only,
#{colors.$db-adaptive-bg-basic-level-1-default}
#{colors.$db-adaptive-bg-basic-transparent-full-default}
) !important;
}
}
Expand Down
2 changes: 0 additions & 2 deletions showcases/shared/input.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,15 +128,13 @@
"name": "(Default) False",
"props": {
"label": "Label",
"value": "(Default) False",
"readOnly": false
}
},
{
"name": "True",
"props": {
"label": "Label",
"value": "True",
"readOnly": true
}
}
Expand Down
Loading