refactor: replaced font leftovers of release 2.x
#4695
+8
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g-default-mappings-for-headlines
There was a problem hiding this comment.
Pull Request Overview
This refactor consolidates font-related CSS custom properties by replacing separate font-size and line-height declarations with a single font shorthand property. The changes eliminate leftovers from release 2.x that used individual font properties.
- Replaces separate
font-sizeandline-heightproperties withfontshorthand across multiple files - Updates code examples and documentation to reflect the new consolidated approach
- Simplifies CSS declarations by reducing two properties to one
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| showcases/patternhub/styles/decision-tree.scss | Updates h2 styles to use consolidated font property |
| showcases/patternhub/pages/foundations/font-sizes/overview.tsx | Updates code examples and inline styles to use font shorthand |
| packages/foundations/docs/FontsSizes.md | Updates documentation example to show font shorthand usage |
| <code>--db-type-headline-font-size-XX</code> | ||
| <br /> | ||
| <code>--db-type-headline-line-height-XX</code> | ||
| <code>--db-type-headline-XX</code> |
There was a problem hiding this comment.
The documentation should clarify what properties are included in the --db-type-headline-XX shorthand property. Users migrating from the old individual properties need to understand that this includes both font-size and line-height.
Suggested change
| <code>--db-type-headline-XX</code> | |
| <code>--db-type-headline-XX</code> | |
| <span style={{ display: 'block', marginTop: 4 }}> | |
| <em> | |
| This shorthand custom property sets both <code>font-size</code> and <code>line-height</code>. | |
| </em> | |
| </span> |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Resolves #4652
Types of changes
Further comments