Skip to content

fix(tooltip & popover): playwright visual regression tests #4696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

fix(tooltip & popover): playwright visual regression tests #4696

wants to merge 3 commits into from
+10 −2

Conversation

mfranzke
Copy link
Collaborator

@mfranzke mfranzke commented Aug 6, 2025

Proposed changes

Resolves #4671

Types of changes

  • Bugfix (non-breaking change that fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improvements to existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke self-assigned this Aug 6, 2025
@mfranzke mfranzke requested a review from nmerget as a code owner August 6, 2025 15:44
@mfranzke mfranzke added the 🐛bug Something isn't working label Aug 6, 2025
@mfranzke mfranzke linked an issue Aug 6, 2025 that may be closed by this pull request
DBTag: Tooltip's JS animation leads to breaking tests #4671
Open
7 tasks
@mfranzke mfranzke added the 👩‍👧‍👦communityFeedback Feedback from community label Aug 6, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2025

🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/4671-dbtag-tooltips-js-animation-leads-to-breaking-tests

@mfranzke mfranzke moved this to 🕋 In progress in UX Engineering Team Backlog Aug 6, 2025
@github-actions
auto update snapshots (#4698)
112f7ef 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@mfranzke mfranzke marked this pull request as draft August 7, 2025 08:00
@mfranzke
Copy link
Collaborator Author

mfranzke commented Aug 11, 2025 •
edited
Loading

@annsch as aligned, could you please test with version 3.0.4-playwright-visual-regression2-5008387 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget Awaiting requested review from nmerget nmerget is a code owner

@michaelmkraus michaelmkraus Awaiting requested review from michaelmkraus michaelmkraus will be requested when the pull request is marked ready for review michaelmkraus is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@mfranzke mfranzke

Labels
🐛bug Something isn't working 👩‍👧‍👦communityFeedback Feedback from community
Projects
UX Engineering Team Backlog
Status: 🕋 In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DBTag: Tooltip's JS animation leads to breaking tests
1 participant
@mfranzke