refactor(pre-commit): not running jscpd anymore
#4710
Merged
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`jscpd` leads to a 10 seconds delay of a git commit, as it needs to parse through the whole codebase to detect any copy&paste code parts. As we're doing within the pipeline even already, we should skip it on localhost due to this massive delay.
|
🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/refactor-pre-commit-not-running-jscpd-anymore |
mfranzke
changed the title
jscpd anymorepre-commit): not running jscpd anymore
There was a problem hiding this comment.
Pull Request Overview
This PR removes the jscpd (JavaScript Copy Paste Detector) tool from the pre-commit hook to improve local development experience by eliminating a 10-second delay during Git commits. The change maintains code quality by keeping the duplicate code detection in the CI pipeline.
- Removes
npm run lint:jscpdfrom the pre-commit hook - Improves developer experience by reducing commit time
michaelmkraus
approved these changes
Aug 12, 2025
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in UX Engineering Team Backlog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
jscpdcauses a 10-second delay to a Git commit because it needs to parse the entire codebase to detect any copied and pasted code. Since we are already doing this within the pipeline, we should skip it on localhost due to the significant delay.Resolves #3018
Types of changes
Further comments