Skip to content

style(badge): added a min-inline-size #4715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

mfranzke
Copy link
Collaborator

@mfranzke mfranzke commented Aug 11, 2025

Proposed changes

Added a min-inline-size especially for single character contents, to ensure that it won't get any narrower than a circle.

Resolves db-ux-design-system/core#372

Types of changes

  • Bugfix (non-breaking change that fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improvements to existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

especially for single character contents
@mfranzke mfranzke self-assigned this Aug 11, 2025
@mfranzke mfranzke added the 🍄🆙improvement New feature or request label Aug 11, 2025
@mfranzke mfranzke added the 👩‍👧‍👦communityFeedback Feedback from community label Aug 11, 2025
@mfranzke mfranzke linked an issue Aug 11, 2025 that may be closed by this pull request
7 tasks
Copy link
Contributor

@mfranzke mfranzke moved this to 👀 In review in UX Engineering Team Backlog Aug 11, 2025
@mfranzke mfranzke removed their assignment Aug 11, 2025
@mfranzke mfranzke enabled auto-merge (squash) August 11, 2025 16:24
github-actions bot and others added 5 commits August 11, 2025 16:43
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@mfranzke mfranzke changed the title style(badge): added a min-inline-size style(badge): added a min-inline-size Aug 12, 2025
@mfranzke mfranzke requested a review from Copilot August 12, 2025 07:00
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👩‍👧‍👦communityFeedback Feedback from community 🍄🆙improvement New feature or request
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

Text Badge sollte nicht schmaler als rund werden
1 participant