Drop the official Datadog client #144
Conversation
This drops our dependency on `@datadog/datadog-api-client` in favor of directly calling the API via HTTP. It requires a little more code on our side, but gets us a bit more flexibility and drops a 15 MB (!) dependency that we barely use. Fixes #132.
Not strictly required for this PR, but these changes help make tests a safer and more consistent regardless of what env vars you have set.
| get () { return false; }, | ||
| set () {}, | ||
| }); | ||
| class HttpApi { |
There was a problem hiding this comment.
Probably want to either merge this into DatadogReporter or pull some more logic from it (e.g. base URL stuff) down into this class.
|
Thanks for this, I appreciate the thought behind this! |
|
@jonathanstiansen do need support for Node.js < 12? Would you be interested in testing a pre-release version of this? |
|
Nope!
…On Sun, Apr 13, 2025 at 10:59 AM Rob Brackett ***@***.***> wrote:
@jonathanstiansen <https://github.com/jonathanstiansen> do need support
for Node.js < 12?
Would you be interested in testing a pre-release version of this?
—
Reply to this email directly, view it on GitHub
<#144 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAR7T2EL6DJESUAO2YU2YL32ZKJXJAVCNFSM6AAAAABUQWABPCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMBQGAZTENRUGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
*Mr0grog* left a comment (dbader/node-datadog-metrics#144)
<#144 (comment)>
@jonathanstiansen <https://github.com/jonathanstiansen> do need support
for Node.js < 12?
Would you be interested in testing a pre-release version of this?
—
Reply to this email directly, view it on GitHub
<#144 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAR7T2EL6DJESUAO2YU2YL32ZKJXJAVCNFSM6AAAAABUQWABPCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMBQGAZTENRUGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@dbader : can we merge this please? |
|
@kroney thanks for the ping here! I think I should have some time to return to this in the next week or so. re: the original notes here, I think I will probably update the minimum required version of Node.js (since datadog-ci has also upgraded) so this can also resolve some the other warnings. That will make this a 0.13.0 release. |
|
@Mr0grog any updates? |
|
@kroney this is definitely still on my radar as a high priority, but I just haven’t had the time I thought I would. Is this especially important for you? I could push out an alpha release this weekend with what’s here so far and none of the other cleanup. Also, what’s the oldest Node.js release you are currently using this package with? Thinking about how far to move the minimum with this update. |
|
We have some issues with this package and memory in AWS lambda, that's why it would be nice to see if it works. We're running at least node 20 everywhere |
|
OK, this should be good to go as far as a pre-release ( Things I want to make sure I cover before a final v0.13.0:
|
|
@kroney (and anyone else here interested), this is now available on NPM and you can install it by setting the
Please post issues if you run into problems! And sorry this has been so slow coming. |
|
@kroney did this change help your issues at all? |
This is a first pass, and is a bit speculative. This PR drops the official Datadog client as a runtime dependency since it is huge (15 MB!) and imposes a lot of runtime costs and some logging confusion (e.g. #133).
The implementation here basically swaps out
@datadog/datadog-api-clientforcross-fetch, which is what@datadog/datadog-api-clientwas using, so the potential issues should be pretty minimal here.I was hoping to fix the punycode deprecation warning, but was not able to do so because the dependencies causing the issue require newer versions of Node.js than we currently do (Node.js 12.0). We can upgrade
cross-fetch(requires Node.js 14.0) or switch directly tonode-fetch(requires Node.js 12.20, but cuts off the tacit-but-not-guaranteed-compatibility we have with React Native and with Browsers). Either one of these is probably OK (Node.js maintenance only extends back to v18 these days anyway, and our biggest dependee, datadog-ci, only requires Node.js 14). Something to think through before landing this.