Skip to content

Clean up Modal and Popover props #1090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 22, 2025
Merged

Clean up Modal and Popover props #1090

merged 2 commits into from
Feb 22, 2025

Conversation

@tcbegley
Copy link
Collaborator

@tcbegley tcbegley commented Feb 22, 2025

  • Delete inner_class_name / innerClassName from Popover as it had no effect
  • Ensure dialog_class_name targets same element as dialog_style
  • Rename modal_class_name to class_name
  • Add backdrop_style prop.

@tcbegley tcbegley changed the base branch from main to dash-3.0 February 22, 2025 07:09
@tcbegley tcbegley merged commit 1fe6983 into dash-3.0 Feb 22, 2025
8 checks passed
@tcbegley tcbegley deleted the check-props branch February 22, 2025 07:15
This was referenced Mar 11, 2025
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tcbegley