feat: use URL for logo in README so it displays properly on PyPI. #1093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original code used a relative path to the logo file in `README.md`, but that does not resolve properly when the package is uploaded to pypi.org. This PR replaces the relative path with the full GitHub URL to the logo file, which is clunky but works.
tcbegley
reviewed
Feb 28, 2025
Collaborator
tcbegley
left a comment
tcbegley
left a comment
There was a problem hiding this comment.
Thanks for this! Made a suggestion inline, wdyt?
tcbegley
reviewed
Feb 28, 2025
Co-authored-by: Tom Begley <[email protected]>
Contributor
Author
|
Suggestion accepted - thanks @tcbegley |
tcbegley
approved these changes
Feb 28, 2025
Collaborator
|
Thanks for the contribution! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original code used a relative path to the logo file in
README.md, but that does not resolve properly when the package is uploaded to pypi.org. This PR replaces the relative path with the full GitHub URL to the logo file, which is clunky but works.