Require a more recent version of the wcwidth dependency#1683
Open
rolandwalker wants to merge 1 commit intomainfrom
Open
Require a more recent version of the wcwidth dependency#1683rolandwalker wants to merge 1 commit intomainfrom
rolandwalker wants to merge 1 commit intomainfrom
Conversation
The transitive version through cli_helpers is not always up to date. The motivation is to get better rendering of tables when there are Unicode characters therein, especially emoji and CJK characters.
d413a20 to
d1c91ae
Compare
No direct security issues found in this diff. Missing test/coverage gap:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The transitive version of wcwidth through cli_helpers->tabulate is not always up to date.
I'm not sure I can explain why this is, only that when installing the mycli wheel from PyPi, it pulls in wcwidth 0.2.14, which is inferior. Maybe this is because cli_helpers uses a setup.py instead of a pyproject.toml? Maybe because cli_helpers declares that it can run on Python 3.6? In any case, we can fix it here for mycli.
The motivation is to get better rendering of tables when there are Unicode characters therein, especially emoji and CJK characters.
Checklist
changelog.mdfile.AUTHORSfile (or it's already there).