Open
Conversation
* sqlexecute.run() no longer returns a tuple, but a Generator of SQLResults * move sqlexecute.connect() within a try block * clarify inner error as e2 * grammar and spelling in commentary * if raising a CommandNotFound(), show the command (this can be part of the relevant backtrace) Due to the first and second bullet, an interrupted query would indeed be cancelled, but the user would at minimum receive poor feedback, and the mycli session could also end. It might also be desirable to tell click not to handle KeyboardInterrupt.
0671599 to
0674876
Compare
|
No correctness or security regressions stood out in the PR diff itself. Findings:
Residual risk:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
sqlexecute.run()no longer returns a tuple, but aGeneratorofSQLResultssqlexecute.connect()within atryblocke2CommandNotFound(), show the command (this can be part of the relevant backtrace)Due to the first and second bullet, an interrupted query would indeed be cancelled, but the user would at minimum receive poor feedback, and the mycli session could also end.
It might also be desirable to tell click not to handle
KeyboardInterrupt.Checklist
changelog.mdfile.AUTHORSfile (or it's already there).