Skip to content

when opening a file for execution, use the same encoding as in the da… #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

when opening a file for execution, use the same encoding as in the da… #961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ TBD
Bug Fixes:
----------
* Allow `FileNotFound` exception for SSH config files.
* When opening files for execution, use the same encoding as in the database connection

Features:
---------
Expand Down
2 changes: 1 addition & 1 deletion mycli/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ def execute_from_file(self, arg, **_):
message = 'Missing required argument, filename.'
return [(None, None, None, message)]
try:
with open(os.path.expanduser(arg)) as f:
with open(os.path.expanduser(arg), encoding=self.sqlexecute.charset) as f:
query = f.read()
except IOError as e:
return [(None, None, None, str(e))]
Expand Down