Skip to content

Conversation

@fizyk
Copy link
Member

@fizyk fizyk commented Jan 27, 2026

Chore that needs to be done:

  • Add newsfragment pipenv run towncrier create [issue_number].[type].rst

Types are defined in the pyproject.toml, issue_number either from issue tracker or the Pull request number

Summary by CodeRabbit

  • Tests

    • Optimised test configuration for improved distributed parallel execution across multiple worker processes.
  • Chores

    • Implemented targeted fixes for intermittent CI nondeterministic failures on MacOS. Addressed database initialisation issues in test execution that previously caused resource conflicts when running tests across distributed workers.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 27, 2026

Walkthrough

The pull request adds a pytest xdist group marker to the test_executor_init_with_password test to prevent port conflicts across xdist workers on macOS. A news fragment documents this fix for a sporadic CI failure.

Changes

Cohort / File(s) Summary
Test configuration
tests/test_executor.py
Adds pytest.mark.xdist_group("executor_no_xdist_guard") to test_executor_init_with_password to isolate test execution and prevent concurrent port usage.
Release documentation
newsfragments/+831f24cb.misc.rst
Adds news fragment describing the fix for nondeterministic CI failures on macOS caused by xdist workers competing for database ports during test initialisation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A marker placed with care so fine,
Prevents the port conflicts' design,
On macOS where workers dance,
Now each test gets its rightful chance,
No more "database starting up" cry—
Just smooth CI tests passing by! 🌙

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title refers to fixing a macOS random failure, which aligns with the PR's objective to address a CI nondeterministic failure on macOS, but lacks specificity about what the fix actually addresses (xdist grouping for the test_executor_init_with_password test).
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@newsfragments/`+831f24cb.ci.rst:
- Line 4: Update the sentence fragment "doesn't have a guards" to the correct
grammar "doesn't have guards" in the news fragment string so the line reads
"...That's the only test that doesn't have guards against attempting to start on
the same port as other xdist worker." Search for that exact phrase to locate and
replace it.

@fizyk fizyk force-pushed the macos-system-is-starting-up branch from abecadf to 19546a9 Compare January 27, 2026 20:43
@fizyk fizyk force-pushed the macos-system-is-starting-up branch from 19546a9 to 415bb40 Compare January 27, 2026 20:44
@fizyk fizyk merged commit bf896f1 into main Jan 28, 2026
51 checks passed
@fizyk fizyk deleted the macos-system-is-starting-up branch January 28, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants