Carry commits from newrelic

[olleolleolle]

This PR carries commits mentioned in #16.

• Borrowed the code from newrelic@40d926bf0035b9b20c967b9a4a6d16b4d550ed24\#commitcomment-10737991
• this improves regexes

Questions for reviewer:

• This is a start (Update: I've now taken over the code which was "pickupable")
• What test cases can we modify to cover the new text patterns?
• Do we wish to have a purpose-built dependency_manifest.yml codepath in the gem, or can we offer before and after hooks in the Rake task, to offer manipulability of the licenses information gathered?

Things that stand out:

• ENV['DEBUG'] to enable "debug mode" could become a logger instead Replaced.
• Extract the dependency_manifest things to its own PR

[dblock]

Not sure what tests should be modified, but tests should be modified ;)

Maybe separate the whole dependency manifest stuff into a different PR?

Needs documentation, changelog, etc.

[dblock]

Should live in its own file and be loaded via the above require. See how other gems do this.

[dblock]

Nitpicking, but this could be a when with all three values an license.to.s_upcase.

[dblock]

As you mention this should be a logger.

[olleolleolle]

@dblock Thanks for looking at it - any kind of feedback about this is great.

• Do we wish to have a purpose-built dependency_manifest.yml codepath in the gem, or can we offer before and after hooks in the Rake task, to offer manipulability of the licenses information gathered?

I've now realized that Gem.licenses is the method that such an interested user can make use of. I should write an example for the README, how to do stuff with Gem.licenses in a custom-written Rake task for your CI.

[dblock]

Remaining things are logger (getting rid of debugging?), changelog/readme.

[olleolleolle]

It’s a nice evening for it, so perhaps tonight, in the Copenhagen time zone.

…

On 6 Nov 2017, at 21:47, Daniel Doubrovkine (dB.) @dblockdotorg ***@***.***> wrote: Remaining things are logger (getting rid of debugging?), changelog/readme. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[dblock]

I am still half confused about to_dependency_manifest.rb btw, so maybe split that into a different PR?

[olleolleolle]

@dblock I made the simple decision to follow the logging/output style of the parent class Gem::Specification - use warn to output warnings, and have no other output.

[olleolleolle]

(That's it, for tonight. I'm out of time. See you soon!)