Skip to content

Conversation

@voltechs
Copy link

Can I recommend changing load_tasks to load_tasks to follow a pattern set by Rails?

To my chagrin, it wasn't clear to me immediately that I needed to place this line in the Rakefile. I realize the Readme (sorta) mentions it, but we could clean that up with "Load rake tasks by calling Gem::GemLicenses.load_tasks in a Rakefile.

install_tasks leaves me with the assumption I only need to do it once. I thought perhaps it would copy the .rake files over to my project directory.

I feel silly, but finally figured it out. The intent here would be to prevent someone else from spinning their wheels on this. I started down the rabbit hole of finding a version or rake that was compatible because it kept throwing an error about that. And before that, I'd opened a ticket (sorry) about rake not being loaded.

I know this is a bit nuanced and maybe somewhat subjective, but I figured instead of opening a ticket I'd just do the work to slick the skids. Your gem, your call. Give it some thought!

Cheers!

P.S. Thanks for writing gem-licenses! :)

Provide backwards compat
@dblock
Copy link
Owner

dblock commented Jun 22, 2018

I understand where you're coming from.

Bundler uses Bundler::GemHelper.install_tasks, but Rails uses Rails.application.load_tasks. Other gems do other things.

Supporting both seems like an overkill to me. Supporting only load_tasks would break backwards compatibility.

Maybe we should just improve the README?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants