Load Tasks vs Install Tasks #22
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can I recommend changing
load_taskstoload_tasksto follow a pattern set by Rails?To my chagrin, it wasn't clear to me immediately that I needed to place this line in the Rakefile. I realize the Readme (sorta) mentions it, but we could clean that up with "Load rake tasks by calling
Gem::GemLicenses.load_tasksin aRakefile.install_tasksleaves me with the assumption I only need to do it once. I thought perhaps it would copy the.rakefiles over to my project directory.I feel silly, but finally figured it out. The intent here would be to prevent someone else from spinning their wheels on this. I started down the rabbit hole of finding a version or rake that was compatible because it kept throwing an error about that. And before that, I'd opened a ticket (sorry) about rake not being loaded.
I know this is a bit nuanced and maybe somewhat subjective, but I figured instead of opening a ticket I'd just do the work to slick the skids. Your gem, your call. Give it some thought!
Cheers!
P.S. Thanks for writing
gem-licenses! :)