Skip to content

Conversation

@tobiaszwaszak
Copy link
Contributor

Just added missed description field

@tobiaszwaszak tobiaszwaszak force-pushed the add-description-to-club-event-model branch from 21c2761 to 279c783 Compare March 26, 2025 20:28
@simonneutert
Copy link
Collaborator

Thank you @tobiaszwaszak! Please, follow @dangerpr-bot's suggestion.
Simply put the line below your entry in CHANGELOG.md and update your PR.

@tobiaszwaszak tobiaszwaszak force-pushed the add-description-to-club-event-model branch from 279c783 to 41845b7 Compare March 27, 2025 06:57
@tobiaszwaszak
Copy link
Contributor Author

Thank you @tobiaszwaszak! Please, follow @dangerpr-bot's suggestion. Simply put the line below your entry in CHANGELOG.md and update your PR.

done

@simonneutert simonneutert merged commit 4f4105b into dblock:master Mar 27, 2025
7 checks passed
@dblock
Copy link
Owner

dblock commented Mar 27, 2025

Since this is technically a new feature make a PR to bump the version to 2.3.

We also have these tests that do expect(event.description).to be_a String, but it should really be checking the actual value from the VCR K7, e.g. expect(event.description).to eq 'This is an event.'. Maybe an AI can quickly do that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants