Time parse error for club events #89
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [#89]https://github.com/dblock/strava-ruby-client/pull/89: Fix for time parsing in club events - [@tobiaszwaszak](https://github.com/tobiaszwaszak).Generated by 🚫 Danger |
tobiaszwaszak
force-pushed
the
time-parse-error-for-club-events
branch
from
58456d1 to
9b6e411
Compare
dblock
requested changes
May 31, 2025
Owner
dblock
left a comment
dblock
left a comment
There was a problem hiding this comment.
What is Strava actually returning? If it's nil, then handle this with an if.
property 'created_at', transform_with: ->(v) { Time.parse(v) if v }| @@ -1,5 +1,6 @@ | |||
| ### 2.3.0 (Next) | |||
|
|
|||
| * [#89]https://github.com/dblock/strava-ruby-client/pull/89: Fix for time parsing in club events - [@tobiaszwaszak](https://github.com/tobiaszwaszak). | |||
Owner
There was a problem hiding this comment.
Suggested change
| * [#89]https://github.com/dblock/strava-ruby-client/pull/89: Fix for time parsing in club events - [@tobiaszwaszak](https://github.com/tobiaszwaszak). | |
| * [#89](https://github.com/dblock/strava-ruby-client/pull/89): Fix `nil` time parsing in club events - [@tobiaszwaszak](https://github.com/tobiaszwaszak). |
Contributor
Author
yes its nil |
dblock
requested changes
Jun 3, 2025
Owner
dblock
left a comment
dblock
left a comment
There was a problem hiding this comment.
Fix doesn't seem quite right. Iterate till CI passes too please, CHANGELOG needs an update.
| property 'organizing_athlete', transform_with: ->(oa) { Strava::Models::Athlete.new(oa) } | ||
| property 'activity_type' | ||
| property 'created_at', transform_with: ->(v) { Time.parse(v) } | ||
| property 'created_at', transform_with: ->(v) { Time.parse(v) if v['created_at'] } |
Owner
There was a problem hiding this comment.
This can't be right because v is the time, not v['created_at']. Add a test when the club activity has a created_at time and that test should pass.
Owner
|
Fixed in #95. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably an issue on strava site, but it's easier to handle it on gem side.
When I try to get club events, I have an error:
Looks like there is no information about
created_atThis PR handles that issue