Refactor event model to map 'object_id' to 'id' #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonneutert
force-pushed
the
88-fix-hashie-warning
branch
5 times, most recently
from
fa3c049 to
2293bbb
Compare
simonneutert
changed the title
simonneutert
force-pushed
the
88-fix-hashie-warning
branch
from
2293bbb to
d04765a
Compare
dblock
requested changes
Oct 17, 2025
Owner
There was a problem hiding this comment.
This is backwards incompatible so we need an entry in UPGRADING.md and a bump to 3.0, don't we? Unless there's a way to make it backwards compatible and turn off the warning? Or maybe we should do a 2.4.0 that adds a warning that this is going to be renamed in 3.0?
Feel free to PR the CI changes separately.
simonneutert
force-pushed
the
88-fix-hashie-warning
branch
from
d04765a to
71c7821
Compare
updaetes GitHub CI actions, adds newest Ruby versions to CI
simonneutert
force-pushed
the
88-fix-hashie-warning
branch
from
71c7821 to
25a0480
Compare
Collaborator
Author
Owner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #88
Updates github workflow actions, too.
I am running checkout@v5 action in my repositories without issues.
Adds ruby v3.4 and JRuby v10.
Steps/Changes: