Skip to content

Sync from upstream with transformations#22

Closed
dbookstaber wants to merge 1 commit intomasterfrom
ci/sync-upstream-faa0151
Closed

Sync from upstream with transformations#22
dbookstaber wants to merge 1 commit intomasterfrom
ci/sync-upstream-faa0151

Conversation

@dbookstaber
Copy link
Copy Markdown
Owner

This PR was created automatically by the Sync Upstream workflow.

  • Pulls latest from upstream and applies configured transformations
  • Preserves files listed in sync_config.json under exclude_paths
  • See script at scripts/sync_upstream.py for details

If there are unexpected changes, adjust sync_config.json or update the script.

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @dbookstaber, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is an automated synchronization from an upstream repository, primarily focusing on enhancing the project's documentation, expanding Python version compatibility, and preparing for an upcoming release. It includes a comprehensive overhaul of the API and conceptual documentation, alongside internal code refactorings and dependency adjustments to improve clarity, maintainability, and user experience.

Highlights

  • Documentation Overhaul: Significant updates have been made across the documentation, including a new API overview with a class diagram, expanded drag model concepts with visual aids, and dedicated documentation for drag tables and the logger module. Installation instructions and internal architecture descriptions have also been refined.
  • Expanded Python 3.9 Support: Both the main project and its Cython extensions now officially support Python 3.9, broadening the compatibility for users.
  • Release Candidate Version: The project is moving towards a new release, with the version updated to 2.2.0rc1 for both pyballistic and pyballistic.exts, indicating a release candidate phase.
  • Logger Refactoring: The internal logger import and usage have been refactored for consistency, changing logger to log in pyballistic/__init__.py.
  • Dependency and Configuration Refinements: Optional dependencies for visualization have been renamed from visualize to charts (with visualize added as an alias), and the pyproject.toml files have been updated to reflect these changes and other build system requirements.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, generated by an automated sync workflow, introduces a wide range of updates across the repository. The changes primarily focus on improving documentation by adding a new Mermaid diagram, expanding explanations, and enhancing formatting for better readability. Dependencies and project metadata have also been updated, notably lowering the required Python version to 3.9 for broader compatibility. Overall, the changes are positive and improve the project's quality. I've found one issue in a documentation code example that needs to be corrected.

Comment thread docs/concepts/index.md
ax = result.plot()

# Compute and display danger space for a 10-inch target at 350 yards
danger_space = shot_result.danger_space(Distance.Yard(350), Distance.Inch(10))
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The variable shot_result is used here, but it was not defined in the preceding lines of the example. The correct variable, which holds the result of the calc.fire call, is result. Using an undefined variable will cause the example code to fail.

Suggested change
danger_space = shot_result.danger_space(Distance.Yard(350), Distance.Inch(10))
danger_space = result.danger_space(Distance.Yard(350), Distance.Inch(10))

@dbookstaber dbookstaber deleted the ci/sync-upstream-faa0151 branch September 22, 2025 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant