-
Notifications
You must be signed in to change notification settings - Fork 41
Fix: Register WorkflowHandle for gob encoding automatically #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The workflow handlers registered are:
Now I need to make changes in the tests? // @maxdml |
|
Thanks @vr-varad , yes we should have a test (either modifying an existing one or adding a new one) where a workflow and a step would return a I don't think we need to register |
|
Does the failing test mean the registration has failed? // @maxdml |
|
|
@vr-varad the issue is that we can't automatically register interfaces during RegisterWorkflow. In this case, when you try to register a workflow that returns an interface, behind the hood we create a zero value and attempt to register it. For all zero values, this works fine, but for interfaces, gob requires that the underlying concrete type has been registered first. There is another issue I now realize: the workflow handles don't export any field, which makes them unsuitable for encoding as well. In this case let's just cancel this feature, ignore registration of nil interfaces, and ask users to manually register their types. |
|
Makes Sense @maxdml!! |
Fixes #151