System DB config #33
Merged
System DB config #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxdml
commented
Jul 22, 2025
Comment on lines
-114
to
-116
| // XXX doing this lets the dequeue and the task invokation survive the context cancellation | ||
| // We might be OK with not doing this. During the tests it results in all sorts of error inside the two functions above due to context cancellation | ||
| runnerContext := context.WithoutCancel(ctx) |
Collaborator
Author
There was a problem hiding this comment.
This causes a small race condition in the TestWorkerConcurrency test -- I might have to change this test altogether eventually
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let users provide the system db url programmatically