Q dedup and prio

[maxdml]

No description provided.

[Copilot]

Pull Request Overview

This PR adds deduplication and priority features to workflow queues. The implementation introduces a mechanism to prevent duplicate workflows from being enqueued based on a deduplication ID and allows workflows to be prioritized for execution order.

• Adds WithDeduplicationID and WithPriority workflow options for configuring queue behavior
• Implements deduplication logic that throws QueueDeduplicated error when duplicate workflows are detected
• Extends queue system to support priority-based execution ordering

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
dbos/workflow.go	Adds deduplication and priority parameters to workflow options and enqueue functionality
dbos/system_database.go	Implements deduplication constraint handling with proper error detection
dbos/errors.go	Defines new QueueDeduplicated error type for deduplication violations
dbos/queues_test.go	Comprehensive test coverage for deduplication and priority queue features
dbos/client_test.go	Client-side tests for deduplication and priority functionality
dbos/workflows_test.go	Minor test improvements and timeout adjustments

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[kraftp]

This looks good! Only thing I'd check is that it should be easy to check if an error is the deduplicated error so it can be handled specially.

[maxdml]

This looks good! Only thing I'd check is that it should be easy to check if an error is the deduplicated error so it can be handled specially.

Here's how you'd do the check (https://github.com/dbos-inc/dbos-transact-go/pull/55/files#diff-305ba99507d11e31f033fa05624d0ed3fc5bcda80bfa2e1fc70603c974cdfcdbR306)

_, err = RunAsWorkflow(dbosCtx, testWorkflow, "def", WithQueue(dedupQueue.Name), WithWorkflowID(wfid2), WithDeduplicationID(dedupID))
require.Error(t, err, "expected error when enqueueing workflow with same deduplication ID")

// Check that it's the correct error type and message
dbosErr, ok := err.(*DBOSError)
require.True(t, ok, "expected error to be of type *DBOSError, got %T", err)
assert.Equal(t, QueueDeduplicated, dbosErr.Code, "expected error code to be QueueDeduplicated")