Skip to content

flatten send and set event arguments #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 19, 2025
Merged

flatten send and set event arguments #62

merged 3 commits into from
Aug 19, 2025

Conversation

@maxdml
Copy link
Collaborator

@maxdml maxdml commented Aug 19, 2025 •
edited
Loading

  • Flatten send and set event inputs
  • Simplify get /recv inputs
  • Fix Sleep and Cancel interface signature to accept the context and match the package level methods ( 😢 )

@maxdml maxdml marked this pull request as ready for review August 19, 2025 00:32
kraftp
kraftp reviewed Aug 19, 2025
View reviewed changes
dbos/workflow.go Outdated

// WorkflowGetEventInput defines the parameters for retrieving an event from a workflow.
type WorkflowGetEventInput struct {
// GetEventInput defines the parameters for retrieving an event from a workflow.
Copy link
Member

@kraftp kraftp Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're going to make one in the pair flat, they should both be flat

@maxdml maxdml merged commit abb9d03 into main Aug 19, 2025
2 checks passed
@maxdml maxdml deleted the send-setevent-ux branch August 19, 2025 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kraftp kraftp kraftp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maxdml @kraftp