Shutdown/Cancel interface, "Deactivate" #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxdml
changed the title
maxdml
commented
Aug 20, 2025
Comment on lines
+559
to
+571
| done := make(chan struct{}) | ||
| go func() { | ||
| as.wg.Wait() | ||
| close(done) | ||
| }() | ||
|
|
||
| select { | ||
| case <-done: | ||
| as.logger.Info("Admin server shutdown complete") | ||
| case <-ctx.Done(): | ||
| as.logger.Warn("Admin server shutdown timed out") | ||
| } | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
It turns out that Shutdown on http.Server is non blocking and graceful, i.e., it doesn't terminate existing connections. Waiting on the goroutine that started it to be done is a clean(er) way to wait for the server's full termination.
maxdml
commented
Aug 20, 2025
Comment on lines
+406
to
+409
| c.logger.Info("Queue runner completed") | ||
| c.queueRunner = nil | ||
| case <-time.After(timeout): | ||
| c.logger.Warn("Timeout waiting for queue runner to complete", "timeout", timeout) |
Collaborator
Author
There was a problem hiding this comment.
we cannot safely set the pointer to nil in case of timeout: the resource might yet to be accessed, which would cause a panic.
kraftp
reviewed
Aug 20, 2025
kraftp
reviewed
Aug 20, 2025
kraftp
reviewed
Aug 20, 2025
maxdml
changed the title
kraftp
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.