Conversation
kraftp
reviewed
Feb 18, 2025
kraftp
reviewed
Feb 18, 2025
kraftp
reviewed
Feb 18, 2025
maxdml
commented
Feb 19, 2025
| def test_worker_concurrency_with_n_dbos_instances(dbos: DBOS) -> None: | ||
|
|
||
| # Ensure children processes do not share global variables (including DBOS instance) with the parent | ||
| multiprocessing.set_start_method("spawn") |
Contributor
Author
There was a problem hiding this comment.
Found out that GHA uses "fork", which ofc shares the parent's global variable with the child, including the DBOS global instance, which would result in a DBOS Initialized multiple times with conflicting configuration / fastapi information error in the children.
kraftp
reviewed
Feb 20, 2025
kraftp
approved these changes
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FOR UPDATE NO WAITto lock the rows -- and fail early when failing to do so.test_worker_concurrency_with_n_dbos_instancestest to enforce global concurrency.Note we now ignore
LockNotAvailableerrors.Nit: this PR also adds a nifty information: an

application_namewhich can be used for debugging.