Conversation
dbos/_core.py
Outdated
| output = wf_handle.get_result() | ||
| return output | ||
| except DBOSWorkflowCancelledError as error: | ||
| if status["queue_name"] is not None: |
There was a problem hiding this comment.
We discussed this is the TS PR as well.
I think this is needed. From here the error goes to the client.
If we don'nt remove it like the other error handlers do, I think it will get retried.
There was a problem hiding this comment.
Is it needed? Doesn't the main cancel handler already remove it from the queue?
There was a problem hiding this comment.
What main handler are you referring to ?
My understanding of the code is that , once the error is re thrown here , it goes to the caller. There is no other except clause to catch it.
There was a problem hiding this comment.
The actual cancel handler, in https://github.com/dbos-inc/dbos-transact-py/blob/main/dbos/_workflow_commands.py, which calls
dbos-transact-py/dbos/_sys_db.py
Line 426 in 5d552ba
2 participants
No description provided.