Conversation
qianl15
reviewed
Mar 17, 2026
qianl15
reviewed
Mar 17, 2026
qianl15
approved these changes
Mar 17, 2026
Member
qianl15
left a comment
qianl15
left a comment
There was a problem hiding this comment.
Looks good. Though I was initially confused because we already have a _notification_listener_polling_interval_sec (default to 1.0 sec) when listen/notify is disabled. The name is confusing; if you want, we can change it to _notification_backup_polling_interval or something clearer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #562