Skip to content

Conversation

@colin-rogers-dbt
Copy link
Contributor

@colin-rogers-dbt colin-rogers-dbt commented May 28, 2025

Split off file_format + base testing into: #1134
BigQuery Catalog Config will now support the following:

"name": "basic_iceberg_catalog_integration",
"catalog_type": "generic",
"file_format": "parquet",
"table_format": "iceberg",
"external_volume": "gs://my_bucket",

we then generate storage_uri based like "<external_volume>/_dbt/<schema>/<model>"

Model Config will now support changing this behavor
Full override via specifying storage_uri:

{{ config (
     "catalog": basic_iceberg_catalog_integration
      "storage_uri": "gs://my_different_bucket" # overrides the external volume
      )
 }}

OR
mirroring the functionality in dbt-snowflake, override the _dbt signifier with base_location_root:

{{ config (
     "catalog": basic_iceberg_catalog_integration
      "base_location_root": "different" # gs://my_bucket/different/<schema>/<model>
      )
 }}

dependent on: dbt-labs/dbt-core#11695

resolves #
docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes The PR author has signed the CLA label May 28, 2025
@cla-bot cla-bot bot temporarily deployed to dbt-spark May 28, 2025 20:03 Inactive
@cla-bot cla-bot bot temporarily deployed to dbt-spark May 28, 2025 20:03 Inactive
@cla-bot cla-bot bot temporarily deployed to dbt-athena May 28, 2025 20:03 Inactive
@cla-bot cla-bot bot temporarily deployed to dbt-spark May 28, 2025 20:03 Inactive
@cla-bot cla-bot bot temporarily deployed to dbt-snowflake May 28, 2025 20:03 Inactive
@cla-bot cla-bot bot temporarily deployed to dbt-redshift May 28, 2025 20:03 Inactive
@cla-bot cla-bot bot temporarily deployed to dbt-spark May 28, 2025 20:03 Inactive
@cla-bot cla-bot bot temporarily deployed to dbt-postgres May 28, 2025 20:03 Inactive
@cla-bot cla-bot bot temporarily deployed to dbt-spark May 28, 2025 20:03 Inactive
@cla-bot cla-bot bot temporarily deployed to dbt-spark May 28, 2025 20:03 Inactive
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change in the dbt-adapters package. For details on how to document a change, see the Contributing Guide.

@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change in the dbt-bigquery package. For details on how to document a change, see the Contributing Guide.

@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change in the dbt-tests-adapter package. For details on how to document a change, see the Contributing Guide.

@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change in the dbt-snowflake package. For details on how to document a change, see the Contributing Guide.

@colin-rogers-dbt colin-rogers-dbt changed the title file_format + bigquery storage_uri updates bigquery storage_uri updates Jun 3, 2025
Copy link
Contributor

@mikealfare mikealfare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One and a half concerns and one nit.

@colin-rogers-dbt colin-rogers-dbt enabled auto-merge (squash) June 3, 2025 22:31
@colin-rogers-dbt colin-rogers-dbt merged commit 84890ad into main Jun 3, 2025
20 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the dbt-bigquery/use-external_volume-for-uri branch June 3, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla:yes The PR author has signed the CLA skip:changelog-check Skip changelog verification in a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants