Skip to content

Conversation

@khuston
Copy link

@khuston khuston commented Oct 15, 2025

resolves #172

Problem

Identifiers are not quoted in grant and revoke statements for Redshift. This causes errors when an identifier contains certain characters such as .

Solution

Identifiers are now quoted in grant and revoke statements. Because identifiers can be preceded by the reserved words role or group, we separate those reserved keywords before quoting and then rejoin with a space.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@khuston khuston requested a review from a team as a code owner October 15, 2025 00:58
@cla-bot
Copy link

cla-bot bot commented Oct 15, 2025

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @khuston

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] GRANT revoke statements in redshift fails when usernames contain certain characters (eg. .)

1 participant