Extend Eligible Nodes for ConfigSelectorMethod to include Saved Query Nodes#11635
Open
Extend Eligible Nodes for ConfigSelectorMethod to include Saved Query Nodes#11635
Conversation
Contributor
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11635 +/- ##
==========================================
- Coverage 91.90% 91.84% -0.06%
==========================================
Files 199 199
Lines 24363 24380 +17
==========================================
+ Hits 22390 22391 +1
- Misses 1973 1989 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
… to select from all configurable nodes
…ethod from SelectorMethod class
3179d46 to
5d37b84
Compare
QMalcolm
requested changes
Aug 19, 2025
Contributor
QMalcolm
left a comment
There was a problem hiding this comment.
❤️ This looks great! One thing though, we should add some tests! I think the most appropriate place would be to add them to tests/functional/selectors/
Contributor
Author
|
@QMalcolm added some unit & functional tests! |
QMalcolm
approved these changes
Aug 21, 2025
Contributor
QMalcolm
left a comment
There was a problem hiding this comment.
Amazing, thank you so much!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #11607
Problem
Today, our ConfigSelectorMethod supports selection from parsed and source nodes only.
As an example, you can do this
dbt ls -s config.meta.contains_pii:true, but this command won't return any semantic layer saved queries that have this meta key in the config, despite us using configs for other purposes (as documented).Solution
This PR changes the nodes used by the
ConfigSelectorMethodto useall_nodesmethod instead ofconfigurable_nodes. It's the case thatall_nodesin that method are actually configurable.configurable_nodesmethod was only used in theConfigSelectorMethod, so this change renders the method unused so we can remove it.Checklist