Skip to content

Extend Eligible Nodes for ConfigSelectorMethod to include Saved Query Nodes #11635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Extend Eligible Nodes for ConfigSelectorMethod to include Saved Query Nodes #11635

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
83578af
feat(core/dbt/graph/selector_methods.py): update ConfigSelectorMethod…
trouze May 16, 2025
3481c3c
feat(core/dbt/graph/selector_methods.py): remove configurable_nodes m…
trouze May 16, 2025
5d37b84
fix(core/dbt/graph): remove unused ResultNode from selector_methods
trouze Jun 27, 2025
c4d8f3c
chore: add functional and unit tests for ConfigSelectorMethod
trouze Aug 20, 2025
70b1691
chore: update functional tests for ConfigSelectorMethod
trouze Aug 20, 2025
3b12a36
chore: cleanup config selection functional tests
trouze Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Features-20250627-094000.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Features
body: Let ConfigSelectorMethod search through all nodes to return matching selections
time: 2025-06-27T09:40:00.485654-05:00
custom:
Author: trouze
Issue: "11607"
8 changes: 1 addition & 7 deletions core/dbt/graph/selector_methods.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
ManifestNode,
Metric,
ModelNode,
ResultNode,
SavedQuery,
SemanticModel,
SingularTestNode,
Expand Down Expand Up @@ -205,11 +204,6 @@ def all_nodes(
self.saved_query_nodes(included_nodes),
)

def configurable_nodes(
self, included_nodes: Set[UniqueId]
) -> Iterator[Tuple[UniqueId, ResultNode]]:
yield from chain(self.parsed_nodes(included_nodes), self.source_nodes(included_nodes))

def non_source_nodes(
self,
included_nodes: Set[UniqueId],
Expand Down Expand Up @@ -536,7 +530,7 @@ def search(
# search sources is kind of useless now source configs only have
# 'enabled', which you can't really filter on anyway, but maybe we'll
# add more someday, so search them anyway.
for unique_id, node in self.configurable_nodes(included_nodes):
for unique_id, node in self.all_nodes(included_nodes):
try:
value = _getattr_descend(node.config, parts)
except AttributeError:
Expand Down