Skip to content

Address Click 8.2+ deprecation warning by using type-checking imports #12039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Address Click 8.2+ deprecation warning by using type-checking imports #12039

wants to merge 3 commits into from

Conversation

@edgarrmondragon
Copy link
Contributor

@edgarrmondragon edgarrmondragon commented Sep 22, 2025 •
edited
Loading

Resolves #12038

Problem

Starting with Click 8.2, OptionParser is deprecated.

Solution

Make those click imports type-checking only.

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@cla-bot cla-bot bot added the cla:yes label Sep 22, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2025

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@edgarrmondragon edgarrmondragon force-pushed the 12038-click-optionparser-deprecationl branch from 6d3b2a1 to 539778b Compare September 22, 2025 21:17
@edgarrmondragon edgarrmondragon marked this pull request as ready for review September 22, 2025 22:57
@edgarrmondragon edgarrmondragon requested a review from a team as a code owner September 22, 2025 22:57
@github-actions github-actions bot added the community This PR is from a community member label Sep 22, 2025
MichelleArk
MichelleArk previously approved these changes Oct 23, 2025
View reviewed changes
@edgarrmondragon
Copy link
Contributor Author

edgarrmondragon commented Oct 31, 2025

FWIW 4693918 gets rid of the warning, but it does so by importing private members of click.parser, so I still think this PR is valuable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichelleArk MichelleArk MichelleArk left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

cla:yes community This PR is from a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Click 8.2+ deprecation warning

2 participants

@edgarrmondragon @MichelleArk