-
Notifications
You must be signed in to change notification settings - Fork 2.2k
perf: replace 'in dict.keys()' with 'in dict' for better performance #12191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
perf: replace 'in dict.keys()' with 'in dict' for better performance #12191
Conversation
Remove unnecessary .keys() calls in dictionary membership checks. This avoids creating view objects and improves readability. - core/dbt/context/base.py: diff_of_two_dicts() - core/dbt/contracts/graph/manifest.py: build_node_edges(), build_macro_edges() - core/dbt/task/init.py: profile check
|
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @christopherrya |
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
7ca1f3b to
afb6c14
Compare
afb6c14 to
84585cb
Compare
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (75.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #12191 +/- ##
==========================================
- Coverage 91.99% 91.93% -0.06%
==========================================
Files 203 203
Lines 24863 24863
==========================================
- Hits 22872 22859 -13
- Misses 1991 2004 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
@christopherrya we started requiring commits with verified signatures a few months ago. Unfortunately, we need to get the commits of this PR signed before we can proceed 😞 If you don't have a GPG key already github has guides Generating a new GPG key |
Remove unnecessary .keys() calls in dictionary membership checks. This avoids creating view objects and improves readability.
Resolves #
Problem
Solution
Checklist