Skip to content

Conversation

fornwall
Copy link
Contributor

@fornwall fornwall commented Jul 8, 2025

Fixes #353.

Another alternative to keep the tests as normal tests is to use a mutex (possibly as a macro, as in https://github.com/Thomasdezeeuw/std-logger/blob/17fd34131a1b71063139e393de949a54990b2ef8/src/tests.rs#L14-L33).

@fornwall fornwall requested a review from a team as a code owner July 8, 2025 09:57
@cla-bot cla-bot bot added the cla:yes label Jul 8, 2025
@fornwall fornwall changed the title Run tests modifying DBT_ENV_PRIVATE_GIT_PROVIDER_INFO serially Run tests modifying DBT_ENV_PRIVATE_GIT_PROVIDER_INFO sequentially Jul 8, 2025
@fornwall fornwall force-pushed the fix-352-flaky-tests branch 2 times, most recently from 19e7933 to 2302fa3 Compare July 8, 2025 10:28
@fornwall
Copy link
Contributor Author

fornwall commented Jul 9, 2025

I see now that cargo-nextest is the recommended test runner - and there a process per test is used, which avoids the issues here.

I personally think that is has value to also support normal cargo test if the cost is not huge - so I think it makes sense fixing this.

@fornwall fornwall force-pushed the fix-352-flaky-tests branch from 2302fa3 to 8242e32 Compare July 9, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] dbt-deps tests are flaky when running multi-threaded

3 participants