fix: Enable to parse YAML with --vars
#403
Conversation
Signed-off-by: Yu Ishikawa <[email protected]>
Signed-off-by: Yu Ishikawa <[email protected]>
Signed-off-by: Yu Ishikawa <[email protected]>
Signed-off-by: Yu Ishikawa <[email protected]>
Signed-off-by: Yu Ishikawa <[email protected]>
|
@joellabes I am sorry for bothering you. Can you please review the PR? |
|
@dataders @dbeatty10 could one of you help move this and #407 forward please? |
crates/dbt-common/src/io_args.rs
Outdated
| // Disallow the '{key:value}' format for flow-style YAML syntax | ||
| // to prevent key:value: None interpretation: https://stackoverflow.com/a/70909331 |
There was a problem hiding this comment.
This comment is misplaced here but could be removed if you move the stackoverflow link to the comment before vars.starts_with(...
There was a problem hiding this comment.
I moved the comment before vars.tarts_with(....
crates/dbt-common/Cargo.toml
Outdated
| serde_json = { workspace = true } | ||
| stringmetrics = { workspace = true } | ||
| strum = { workspace = true } | ||
| strum = { workspace = true, features = ["derive"] } |
There was a problem hiding this comment.
Is this really necessary? If yes, can you move it to the root Cargo.toml?
There was a problem hiding this comment.
I removed this. I needed this to pass the entire unit tests locally. However, it is't relevant to the pull request.
Signed-off-by: Yu Ishikawa <[email protected]>
Signed-off-by: Yu Ishikawa <[email protected]>
|
@felipecrv Thank you for the feedback. I have updated the code. Can you take a look at them again? |
|
@felipecrv Sorry for bothering you, please review the update? |
|
@felipecrv @joellabes Any updates? |
3 participants
Resolves #402