Skip to content

Conversation

johnedmonds
Copy link

Windows doesn't necessarily set the HOME environment variable so I'm using Rust's home_dir instead.

@johnedmonds johnedmonds requested a review from a team as a code owner September 9, 2025 15:38
Copy link

cla-bot bot commented Sep 9, 2025

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @johnedmonds

Copy link

github-actions bot commented Sep 9, 2025

This repository enforces signed commits. Please sign your commits by following the docs here.

Copy link

github-actions bot commented Sep 9, 2025

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

cla-bot bot commented Sep 9, 2025

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @johnedmonds

@cla-bot cla-bot bot added the cla:yes label Sep 9, 2025
Copy link
Contributor

@sadboy sadboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General convention is owned -> PathBuf, reference -> &Path.

Otherwise LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants