-
Notifications
You must be signed in to change notification settings - Fork 67
Find the right home directory for Windows. #727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @johnedmonds |
This repository enforces signed commits. Please sign your commits by following the docs here. |
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
38208e9
to
4fabe80
Compare
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @johnedmonds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General convention is owned -> PathBuf
, reference -> &Path
.
Otherwise LGTM, thanks!
Co-authored-by: Bo Lin <[email protected]>
Co-authored-by: Bo Lin <[email protected]>
Co-authored-by: Bo Lin <[email protected]>
Windows doesn't necessarily set the
HOME
environment variable so I'm using Rust'shome_dir
instead.