fix: update format_duration_fixed_width to support >999s #814
+33
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
|
Hi! Thanks for opening and sorry for a belated response, we've been a bit busy in preparation for Coalesce! Totally agree we have to fix this problem and we'd love to get your PR merged, but we are currently refactoring code that emits TUI/log messages and this function will soon move here. Do you mind waiting and rebase your fix when this happens? Or, I can just pull your suggested changes & tests - but that will prevent us from properly capturing the contribution. Let me know what you prefer! |
|
Happy to rebase whenever. Just let me know |
|
@VDFaller ok, will do. stay tuned! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #778