Skip to content
This repository was archived by the owner on Sep 2, 2025. It is now read-only.

Conversation

@prashantpiyush
Copy link

resolves dbt-labs/dbt-adapters#694

Problem

The relation matching logic did not consider already
quoted relation path parts.

Solution

This diff updates the relation match logic to use the
same casing for quoted parts.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@prashantpiyush prashantpiyush requested a review from a team as a code owner December 18, 2024 17:42
@cla-bot
Copy link

cla-bot bot commented Dec 18, 2024

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @prashantpiyush

1 similar comment
@cla-bot
Copy link

cla-bot bot commented Dec 18, 2024

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @prashantpiyush

@amychen1776
Copy link

Thank you @prashantpiyush for opening this up! We will likely review this PR when we tackle this bigger chunk of work to really resolve quoting issues on this adapter at a broader level
dbt-labs/dbt-adapters#704

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Impossible to use adapter.get_relation to find quoted case-sensitive relations in Snowflake

3 participants