Skip to content
This repository was archived by the owner on Sep 2, 2025. It is now read-only.

Conversation

@ntnhaatj
Copy link

resolves dbt-labs/dbt-adapters#475
docs dbt-labs/docs.getdbt.com/#

Problem

Current SASL factory for TSaslClientTransport using SASLClient from pure-sasl which is incompatible with pyhive

Solution

Pyhive provides a wrapper PureSASLClient which implement some missing methods to interact with thrift-sasl.

This MR update to use get_installed_sasl of pyhive to decide which sasl client should be use in current environment.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@ntnhaatj ntnhaatj requested a review from a team as a code owner August 31, 2024 09:42
@cla-bot
Copy link

cla-bot bot commented Aug 31, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: nhat.nguyent.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@ntnhaatj ntnhaatj force-pushed the fix/pure-sasl-compatible branch from 9769fd2 to 6eb39bf Compare August 31, 2024 10:18
@cla-bot
Copy link

cla-bot bot commented Aug 31, 2024

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @ntnhaatj

@ntnhaatj ntnhaatj force-pushed the fix/pure-sasl-compatible branch from 6eb39bf to 8b3380e Compare August 31, 2024 10:22
@cla-bot
Copy link

cla-bot bot commented Aug 31, 2024

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @ntnhaatj

@nqvuong1998
Copy link

nqvuong1998 commented Sep 4, 2024

Hi @McKnight-42 @mikealfare , any update for this PR?

@github-actions
Copy link
Contributor

This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 25, 2025
@alek6dj
Copy link

alek6dj commented Mar 27, 2025

Hello. Will this PR be included in the official code? In our case, it solved a connectivity issue for a major banking client in a Cloudera ecosystem, with Kerberos authentication and a Livy Thrift server.

@github-actions github-actions bot removed the Stale label Mar 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] AttributeError: 'SASLClient' object has no attribute 'start'

3 participants