Open
Conversation
Owner
|
Two concerns:
|
Author
|
Owner
|
If you have ES6 promises, you have Promise.all If you really think this'll be useful, I'm fine with it; please update the READMEs also to mention the new functionality |
Author
|
@dbushong Yes, but if I want to execute items in series, I have nothing :) Readme updated |
| * tasks - An array or object containing functions to run, each function | ||
| should return a promise for an optional value. | ||
| * tasks - An array, object containing functions to run (each function | ||
| should return a promise for an optional value), or an object containing promises that resolve a value |
Owner
There was a problem hiding this comment.
simpler:
"An array or object containing promises or functions to...."
Owner
|
LGTM; one suggested simplification - btw, FFR if you really don't want to use a lib and need to execute things in series you can use reduce: promiseForSeries = [fn1, fn2, fn3].reduce(((p, fn) => p.then(fn)), Promise.resolve())If you have a fixed number of them, it's even more readable to use |
Owner
|
Don't forget to run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows you to send existing promises directly into the parallel call vs. wrapping in a function