fix(llm, llamacpp): Loosen model ID validation#163
Merged
Conversation
The validation logic for model IDs was too strict to support model names often used in the Llama.cpp ecosystem. For example, a model ID like `llamacpp/bartowski_Qwen2.5-7B-Instruct-GGUF_Qwen2.5-7B-Instruct-Q4_K_M.gguf` was previously rejected, but can now be used with JP. Additionally, the model listing implementation was inadvertently left out of the implementation of the Llamacpp provider. This commit fixes that oversight. It should be noted that it is not possible (unless the llama.cpp server is run with the `--alias` flag[1]) to get the proper model name from the API (instead, it points to the model file on disk), so in reality this implementation isn't particularly useful, but at least it doesn't panic anymore. [1]: https://github.com/ggml-org/llama.cpp/blob/8846aace4934ad29651ea61b8c7e3f6b0556e3d2/tools/server/README.md#get-v1models-openai-compatible-model-info-api Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The validation logic for model IDs was too strict to support model names often used in the Llama.cpp ecosystem. For example, a model ID like
llamacpp/bartowski_Qwen2.5-7B-Instruct-GGUF_Qwen2.5-7B-Instruct-Q4_K_M.ggufwas previously rejected, but can now be used with JP.Additionally, the model listing implementation was inadvertently left out of the implementation of the Llamacpp provider. This commit fixes that oversight.
It should be noted that it is not possible (unless the llama.cpp server is run with the
--aliasflag1) to get the proper model name from the API (instead, it points to the model file on disk), so in reality this implementation isn't particularly useful, but at least it doesn't panic anymore.