chore(tools, mcp): Improve error handling and output formatting #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor internal maintenance tools to use a consistent `Outcome` type for errors and successes. This allows for better structured output when tools fail or require user input. Improve the user experience in the CLI by updating MCP tool definitions to support inline result rendering and custom parameter formatting. Specific tools like `fs_create_file` now provide a preview of the content to be created with syntax highlighting. Adjust `cargo_test` to only use one `--cargo-quiet` flag, ensuring that compilation errors are still visible to the LLM when tests fail to run. Signed-off-by: Jean Mertz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor internal maintenance tools to use a consistent
Outcometype for errors and successes. This allows for better structured output when tools fail or require user input.Improve the user experience in the CLI by updating MCP tool definitions to support inline result rendering and custom parameter formatting. Specific tools like
fs_create_filenow provide a preview of the content to be created with syntax highlighting.Adjust
cargo_testto only use one--cargo-quietflag, ensuring that compilation errors are still visible to the LLM when tests fail to run.